Skip to content

Fix shear transformation for multiple axes (#8450) #8452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

EloiNavet
Copy link
Contributor

Fixes #8450 by proper shear composition.

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@ericspod ericspod requested review from Copilot, Nic-Ma and KumoLiu May 16, 2025 12:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses the incorrect shear transformation calculation in 2D by updating the matrix composition.

  • Updated the shear composition for 2D transformations by modifying the identity matrix accordingly.
  • Fixed the shear coefficient application by adjusting the second diagonal element.

@ericspod
Copy link
Member

Hi @EloiNavet thanks for the submission but this does change behaviour significantly as you see in the tests. I realise the shearing behaviour isn't correct but it would change results for a number of tests as well as those we'd see in tutorials. We may need some way of preserving the old behaviour while offering the new fixed behaviour as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shear transformation is incorrect when done on more than one axis
2 participants