Skip to content

910B4-1更新驱动后虚拟化模版变更#57

Open
greatljn wants to merge 1 commit intoProject-HAMi:mainfrom
greatljn:fix_virt_template
Open

910B4-1更新驱动后虚拟化模版变更#57
greatljn wants to merge 1 commit intoProject-HAMi:mainfrom
greatljn:fix_virt_template

Conversation

@greatljn
Copy link

@greatljn greatljn commented Mar 9, 2026

Fixes #56

@hami-robot hami-robot bot requested review from DSFans2014 and archlitchi March 9, 2026 11:22
@hami-robot
Copy link
Contributor

hami-robot bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: greatljn
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
Copy link
Contributor

hami-robot bot commented Mar 9, 2026

Welcome @greatljn! It looks like this is your first PR to Project-HAMi/ascend-device-plugin 🎉

@hami-robot hami-robot bot added the size/XS label Mar 9, 2026
DSFans2014
DSFans2014 reviewed Mar 10, 2026
View reviewed changes
Copy link
Contributor

@DSFans2014 DSFans2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sign off your commit

DSFans2014
DSFans2014 reviewed Mar 10, 2026
View reviewed changes
ascend-device-configmap.yaml
# The memory is used for scheduling so the correct values must be set.
# Template vir05_1c_8g actually provides 16GB memory,
- name: vir05_1c_8g
- name: vir05_1c_16g
Copy link
Contributor

@DSFans2014 DSFans2014 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a comment above implies Template vir05_1c_8g actually provides 16GB memory. I don't know if there are other reasons for setting it to vir05_1c_8g here. @archlitchi

910B4-1更新驱动后虚拟化模版变更
5417dce 
Signed-off-by: lijiangnan <lijiangnan@4paradigm.com>
@greatljn greatljn force-pushed the fix_virt_template branch from 738c343 to 5417dce Compare March 10, 2026 02:29
@greatljn
Copy link
Author

greatljn commented Mar 10, 2026

please sign off your commit

ok, already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archlitchi archlitchi Awaiting requested review from archlitchi

1 more reviewer

@DSFans2014 DSFans2014 DSFans2014 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-signoff: yes size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

910B4-1的显卡在更新驱动之后虚拟化模版发生变更了

2 participants

@greatljn @DSFans2014