Skip to content

fix: change return type of nvml_to_cuda_map to int for consistency #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xrwang8 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: change return type of nvml_to_cuda_map to int for consistency #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eefd84d
fix: change return type of nvml_to_cuda_map to int for consistency
xrwang8 Sep 22, 2025
0b03926
fix: change return type of cuda_to_nvml_map to int for consistency
xrwang8 Sep 22, 2025
fd9f92d
fix: improve nvml_to_cuda_map logic for better mapping validation
xrwang8 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/multiprocess/multiprocess_memory_limit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ void print_all();
int load_env_from_file(char *filename);
int comparelwr(const char *s1,char *s2);
int put_device_info();
unsigned int nvml_to_cuda_map(unsigned int nvmldev);
unsigned int cuda_to_nvml_map(unsigned int cudadev);
int nvml_to_cuda_map(unsigned int nvmldev);
int cuda_to_nvml_map(unsigned int cudadev);

int clear_proc_slot_nolock(int);
#endif // __MULTIPROCESS_MEMORY_LIMIT_H__
Expand Down
12 changes: 6 additions & 6 deletions src/multiprocess/multiprocess_utilization_watcher.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,18 @@ long delta(int up_limit, int user_current, long share) {
return share;
}

unsigned int nvml_to_cuda_map(unsigned int nvmldev){
int nvml_to_cuda_map(unsigned int nvmldev){
unsigned int devcount;
CHECK_NVML_API(nvmlDeviceGetCount_v2(&devcount));
int i=0;
for (i=0;i<devcount;i++){
if (cuda_to_nvml_map(i)==nvmldev)
return i;
for (unsigned int i = 0; i < devcount; i++){
int mapped = cuda_to_nvml_map(i);
if ((mapped >= 0) && (mapped == (int)nvmldev))
return (int)i;
}
return -1;
}

unsigned int cuda_to_nvml_map(unsigned int cudadev){
int cuda_to_nvml_map(unsigned int cudadev){
return cuda_to_nvml_map_array[cudadev];
}

Expand Down