Skip to content

Feature/Add permission object metadata#38

Open
Scoutski wants to merge 9 commits intoPrismatik:masterfrom
ordermentum:master
Open

Feature/Add permission object metadata#38
Scoutski wants to merge 9 commits intoPrismatik:masterfrom
ordermentum:master

Conversation

@Scoutski
Copy link

This branch:

  • Adds a metadata property to the entity objects within the permissions array that can store any additional data.
  • Adds a test to ensure this metadata property can be saved and retrieved from rethinkdb.

test/spec.js Outdated
.auth('test', key)
.send(two)
.end((err, twoRes) => {
console.log(twoRes.body.permissions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky console.log left in there!

test/spec.js Outdated

test('it should allow metadata properties to be posted and returned', function(t) {
const one = genEntity();
// test('it should allow metadata properties to be posted and returned', function(t) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you removed it in the very next commit! HODOR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants