Feature/Add permission object metadata#38
Open
Scoutski wants to merge 9 commits intoPrismatik:masterfrom
ordermentum:master
Open
Feature/Add permission object metadata#38Scoutski wants to merge 9 commits intoPrismatik:masterfrom ordermentum:master
Scoutski wants to merge 9 commits intoPrismatik:masterfrom
ordermentum:master
Conversation
test/spec.js
Outdated
| .auth('test', key) | ||
| .send(two) | ||
| .end((err, twoRes) => { | ||
| console.log(twoRes.body.permissions) |
Contributor
There was a problem hiding this comment.
Sneaky console.log left in there!
Additional tests and log removal
test/spec.js
Outdated
|
|
||
| test('it should allow metadata properties to be posted and returned', function(t) { | ||
| const one = genEntity(); | ||
| // test('it should allow metadata properties to be posted and returned', function(t) { |
Contributor
There was a problem hiding this comment.
Oh, you removed it in the very next commit! HODOR.
…pipeline Feature/devops 144 helm chart pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch: