Use renderers offload helper in renderer client#1452
Merged
Conversation
ApprovabilityVerdict: Approved This PR removes a locally-defined helper function ( You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note
Low Risk
Low risk refactor that only changes where
_maybe_offloadcomes from (and drops an unusedasyncioimport), with no functional changes expected beyond matching upstream behavior.Overview
Switches
verifiers/clients/renderer_client.pyto import and userenderers.client._maybe_offloadinstead of maintaining a local async offload helper.Removes the now-unused local
_maybe_offloadimplementation and theasynciodependency from this module.Reviewed by Cursor Bugbot for commit e2b0685. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove duplicate
_maybe_offloadhelper fromrenderer_clientin favor of shared importDeletes the local
_maybe_offloaddefinition in renderer_client.py and imports it directly fromrenderers.clientinstead. This deduplicates the helper and ensures both modules use the same offload logic.Macroscope summarized e2b0685.