Skip to content

Use renderers offload helper in renderer client#1452

Merged
xeophon merged 1 commit into
mainfrom
renderer-client-use-renderers-offload
May 23, 2026
Merged

Use renderers offload helper in renderer client#1452
xeophon merged 1 commit into
mainfrom
renderer-client-use-renderers-offload

Conversation

@xeophon
Copy link
Copy Markdown
Member

@xeophon xeophon commented May 23, 2026

Summary

  • import the renderer package's private _maybe_offload helper instead of reimplementing it in Verifiers
  • remove the now-unused asyncio import and local helper

Tests

  • uv run --frozen ruff check verifiers/clients/renderer_client.py tests/test_renderer_client.py
  • uv run --frozen pytest tests/test_renderer_client.py
  • pre-commit/pre-push hooks via git commit and git push

Note

Low Risk
Low risk refactor that only changes where _maybe_offload comes from (and drops an unused asyncio import), with no functional changes expected beyond matching upstream behavior.

Overview
Switches verifiers/clients/renderer_client.py to import and use renderers.client._maybe_offload instead of maintaining a local async offload helper.

Removes the now-unused local _maybe_offload implementation and the asyncio dependency from this module.

Reviewed by Cursor Bugbot for commit e2b0685. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove duplicate _maybe_offload helper from renderer_client in favor of shared import

Deletes the local _maybe_offload definition in renderer_client.py and imports it directly from renderers.client instead. This deduplicates the helper and ensures both modules use the same offload logic.

Macroscope summarized e2b0685.

@macroscopeapp
Copy link
Copy Markdown

macroscopeapp Bot commented May 23, 2026

Approvability

Verdict: Approved

This PR removes a locally-defined helper function (_maybe_offload) and imports it from the upstream renderers.client library instead. This is a mechanical code deduplication with no behavior change.

You can customize Macroscope's approvability policy. Learn more.

@xeophon xeophon merged commit 5b3d673 into main May 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant