Fix harness setups

[xeophon]

Summary

• stack this targeted shell fix on Use Earendil Pi package #1442 so the Pi package change stays separate
• replace bash-only double-bracket workdir checks with POSIX single-bracket checks in OpenCode, Pi, and Terminus 2 generated harness scripts
• add focused assertions that generated scripts use the POSIX checks in the affected paths

Verification

• uv run ruff format verifiers/v1/packages/harnesses/opencode.py verifiers/v1/packages/harnesses/pi.py verifiers/v1/packages/harnesses/terminus_2.py tests/test_v1_harbor_cli.py
• uv run ruff check --fix verifiers/v1/packages/harnesses/opencode.py verifiers/v1/packages/harnesses/pi.py verifiers/v1/packages/harnesses/terminus_2.py tests/test_v1_harbor_cli.py
• uv run pytest tests/test_v1_harbor_cli.py -q
• generated OpenCode and Pi MCP setup scripts run successfully under /bin/dash

Note

Fix harness run scripts to use POSIX [ -z ] instead of bash [[ -z ]]

Replaces [[ -z "$*_WORKDIR" ]] with [ -z "$*_WORKDIR" ] in the generated shell scripts for the Pi, OpenCode, and Terminus 2 harnesses. The double-bracket form is a bash extension that fails in POSIX sh environments used by these harnesses.

^{Macroscope summarized 0234bde.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR makes a mechanical shell syntax change from bash-specific [[ ]] to POSIX-compatible [ ] for empty string checks, improving portability. The test additions verify this syntax. The review comments appear to address pre-existing code behavior, not changes in this PR.

^{You can customize Macroscope's approvability policy. Learn more.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f27a6bb588

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Preserve pipeline failures when importing NodeSource key

The new install script pipes curl | gpg --dearmor | tee ... under set -e, but without pipefail only tee’s exit code is checked. If curl or gpg fails (for example a transient download/trust failure), the script can continue and then apt-get update may still return success with warnings, causing apt-get install nodejs to fall back to distro Node rather than Node 22. This silently defeats the main purpose of the change and can reintroduce Pi runtime mismatches.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05f0fce3aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Preserve existing Pi settings when enabling MCP adapter

The new setup script unconditionally rewrites ~/.pi/agent/settings.json with only a packages array, which discards any pre-existing global Pi settings (for example npmCommand, model defaults, retry/session settings, or other required packages). This regression appears when the sandbox image or a reused home directory already contains Pi configuration, and can break runs that depend on those settings; the prior pi install ... -l path did not replace the whole global settings file.

Useful? React with 👍 / 👎.