Skip to content

feat: exclude nodes with zero balance from node_groups #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

noot
Copy link
Contributor

@noot noot commented Jun 23, 2025

  • get and store balance in DiscoveryNode in discovery::chainsync::sync_single_node()
  • in the orchestrator's sync_single_node, handle the case where the node has zero balance by setting status to NodeStatus::LowBalance (todo: is there a non-zero balance we can set this to?)
  • in NodeGroupsPlugin::handle_status_change, dissolve the group if the node has low balance (not sure if this is the intended behaviour)

closes #408

@noot noot requested a review from JannikSt June 25, 2025 17:36
@noot noot marked this pull request as ready for review July 2, 2025 20:06
@JannikSt JannikSt merged commit a282313 into develop Jul 8, 2025
1 check passed
@JannikSt JannikSt deleted the noot/exclude-nodes-by-balance branch July 8, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude nodes from node_groups that have too little funding
2 participants