Skip to content

Security: Unsafe torch.load with weights_only=False enables arbitrary code execution #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Security: Unsafe torch.load with weights_only=False enables arbitrary code execution #2645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/prime_rl/orchestrator/ckpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def load_from_path(self, ckpt_path: Path, progress: Progress, buffer: Buffer) ->
self.logger.info("Skipping progress loading from checkpoint")
else:
with open(ckpt_path / "progress.pt", "rb") as f:
state = torch.load(f, weights_only=False)
state = torch.load(f, weights_only=True)
Copy link
Copy Markdown

@cursor cursor Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe load breaks progress resume

High Severity

load_from_path now calls torch.load with weights_only=True, but save_to_path still writes progress.pt via torch.save containing a live Progress dataclass instance. Restricted unpickling does not allow that custom type unless it is explicitly allowlisted, so resuming orchestrator checkpoints (when progress loading is not skipped) is likely to fail at load time.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f322a5f. Configure here.


# Set progress in-place
for key, value in asdict(state["progress"]).items():
Expand Down