Conversation
mikasenghaas
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation:
Note
Medium Risk
Changes affect MoE training signal assembly and multi-step rollout merging; incorrect routing alignment would skew RL updates, though behavior is heavily asserted in unit tests.
Overview
Adds delta-only routed experts with an explicit
startoffset on compact sidecars: inference serializes/captures usingrouted_experts_prompt_start, and the orchestrator rebuilds dense per-token routing for training by stitching prefix chunks, enforcing delta alignment on extensions, and padding to full sequence length.interleave_rolloutnow picks the longest matching active prefix when several samples overlap (e.g. compaction/rollback), with a warning on ambiguous matches, so regenerated branches are not merged into shorter stale samples.Dependency pin:
vllm-router0.1.25 → 0.1.26 (lockfile updated).Reviewed by Cursor Bugbot for commit cda9b16. Bugbot is set up for automated code reviews on this repo. Configure here.