[codex] fix orchestrator routed experts memory retention#2623
Draft
samsja wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bounded routed-experts memory retention in the orchestrator step loop.
The routed replay path copies each rollout's
tokens["routed_experts"]payload intoTrainingSample.routed_experts, but the original rollout sidecars stayed attached totrain_rolloutsuntil end-of-step cleanup. Theresultslist frominterleave_rollout(...)also kept packed samples alive after the orchestrator had already extractedtrain_examples.This change:
resultslist once samples have been extractedfilter_dfandtiming_dfin the explicit per-step cleanup beforemalloc_trim(0)This reduces per-step RSS retention and peak memory in router replay runs. It does not claim to fix every possible monotonic production leak; ZMQ backpressure and monitor futures remain separate things to inspect if RSS still slopes upward.
Validation
uv run pytest tests/unit/orchestrator/test_trajectories.py tests/unit/orchestrator/test_batch.py -quv run ruff check src/prime_rl/orchestrator/orchestrator.py src/prime_rl/orchestrator/trajectories.pyuv run ruff format --check src/prime_rl/orchestrator/orchestrator.py src/prime_rl/orchestrator/trajectories.py+53.3 MBafter cleanup for the probe payload+0.0 MBmean over baseline)