Fix JS bug in submit: incorrect variable caused missing variant selection#151
Open
saidaLachgar wants to merge 1 commit intoPrestaShop:devfrom
Open
Fix JS bug in submit: incorrect variable caused missing variant selection#151saidaLachgar wants to merge 1 commit intoPrestaShop:devfrom
saidaLachgar wants to merge 1 commit intoPrestaShop:devfrom
Conversation
saidaLachgar
commented
Jul 31, 2025
| Questions | Answers |
|---|---|
| Description? | Fixes a JavaScript bug where an incorrect variable name caused the product reminder submission to ignore the selected product variant. This resulted in reminders being sent without specifying which combination (e.g., size/color) the user wanted to be notified about. The issue occurs on the product page when combinations are available. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | not sure. |
| How to test? | On a product with combinations, go to the front office and try to subscribe for an out-of-stock variant. Before the fix, the reminder would be submitted without specifying the variant. After the fix, the correct variant should be included in the submission and the reminder handled accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.