feat(hook): Add id product attribute to hook#150
Open
Kaikina wants to merge 4 commits intoPrestaShop:devfrom
Open
feat(hook): Add id product attribute to hook#150Kaikina wants to merge 4 commits intoPrestaShop:devfrom
Kaikina wants to merge 4 commits intoPrestaShop:devfrom
Conversation
|
Hello @Kaikina! This is your first pull request on ps_emailalerts repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
boherm
previously approved these changes
May 22, 2025
Member
boherm
left a comment
boherm
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I agree with you, that could be nice to have :)
Author
|
I updated to "id_product_attribute". I didn't see it was a static function (I don't like static functions). So no way of passing "$this". But actually, I think the only missing information while using the hook was the id_product_attribute, so I added it. |
boherm
previously approved these changes
May 22, 2025
Hlavtox
previously approved these changes
May 22, 2025
Author
|
May we merge this branch ? |
nicohery
approved these changes
Jan 5, 2026
jf-viguier
requested changes
Feb 11, 2026
Contributor
jf-viguier
left a comment
jf-viguier
left a comment
There was a problem hiding this comment.
@Kaikina Please update PR description, it's not MailAlert instance anymore.
Kaikina
changed the title
Author
|
@kpodemski @jf-viguier updated. |
github-project-automation
bot
moved this from Ready for review
to Closed
in PR Dashboard
jf-viguier
previously approved these changes
Feb 19, 2026
Touxten
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.