Add date_add, date_upd, soft delete and notification send time by lmeyer1 · Pull Request #120 · PrestaShop/ps_emailalerts

lmeyer1 · 2022-11-04T09:29:11Z

Questions	Answers
Description?	Add fields to the table `ps_mailalert_customer_oos`, in order for merchant to be able to analyze customer needs and behavior.
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#30186. Prerequisite for #28233.
How to test?	Email alerts for customers should just work the same way as before.

There are these improvements in the db:

when a customer subscribes to an alert, the time is saved to date_add
when a notification is sent out, the time is saved to notification_sent and the line is soft-deleted.
the notification is soft deleted on customer request or when a product is deleted
if the customer requests deletion of his data through gdpr, the email address is anonymized.

ps_emailalerts.php

upgrade/upgrade-2.3.4.php

MailAlert.php

marsaldev · 2022-11-18T16:20:20Z

The soft delete is very interesting 👍, let's understand how to manage on legal side tho

lmeyer1 · 2022-11-18T16:28:34Z

The soft delete is very interesting 👍, let's understand how to manage on legal side tho

I missed to delete all customer data. But once this is fixed, there should not remain any legal problem. Don't you think ?

upgrade/upgrade-2.3.4.php

MailAlert.php

marsaldev · 2022-11-29T11:13:39Z

Waiting for you @lmeyer1 😉

jf-viguier · 2023-08-04T12:40:00Z

This PR is blocking 2.4.2 release.

LouisAUTHIE

Thanks

LouisAUTHIE · 2023-08-04T13:26:45Z

@lmeyer1 can you rebase maybe on the latest version of the dev branch to avoid merge worries ?

souvrard · 2023-08-09T10:18:06Z

For information, the install function has a bug preventing database creation: missing coma at the end of line 139

	`deleted` TINYINT NOT NULL DEFAULT 0,
	`notification_sent` DATETIME NULL DEFAULT NULL <===== MISSING COMA
	PRIMARY KEY  (`id_customer`,`customer_email`,`id_product`,`id_product_attribute`,`id_shop`),
`̀`

lmeyer1 · 2023-08-11T14:34:59Z

@LouisAUTHIE I hope the rebase was successful.
@souvrard Thanks for pointing this out.

jf-viguier · 2023-08-04T13:15:15Z

MailAlert.php

+
+    /** @var string Object last modification date */
+    public $date_upd;
+


notification_sent and deleted are missing I guess

jf-viguier · 2023-08-04T13:15:35Z

MailAlert.php

            'id_shop' => ['type' => self::TYPE_INT, 'validate' => 'isUnsignedInt', 'required' => true],
            'id_lang' => ['type' => self::TYPE_INT, 'validate' => 'isUnsignedInt', 'required' => true],
+            'date_add' => ['type' => self::TYPE_DATE, 'validate' => 'isDate'],
+            'date_upd' => ['type' => self::TYPE_DATE, 'validate' => 'isDate'],


notification_sent and deleted are missing I guess

jf-viguier · 2023-08-04T13:16:13Z

upgrade/upgrade-2.3.4.php

+function upgrade_module_2_3_4()
+{
+    $result = Db::getInstance()->execute('ALTER TABLE `' . _DB_PREFIX_ . 'mailalert_customer_oos` ADD `date_add` DATETIME NOT NULL, ADD `date_upd` DATETIME NOT NULL;');
+    $result = $result && Db::getInstance()->execute('ALTER TABLE `' . _DB_PREFIX_ . 'mailalert_customer_oos` ADD `deleted` TINYINT NOT NULL DEFAULT 0, ADD `notification_sent` DATETIME NULL DEFAULT NULL, ADD INDEX (`deleted`)');


this two lines could be in one

upgrade/upgrade-2.4.2.php

lmeyer1 force-pushed the feat-db branch from 91e2636 to 2303341 Compare November 4, 2022 09:35

lmeyer1 closed this Nov 4, 2022

lmeyer1 reopened this Nov 4, 2022

marsaldev added this to the 2.4.1 milestone Nov 18, 2022

marsaldev reviewed Nov 18, 2022

View reviewed changes

ps_emailalerts.php Show resolved Hide resolved

marsaldev reviewed Nov 18, 2022

View reviewed changes

upgrade/upgrade-2.3.4.php Outdated Show resolved Hide resolved

marsaldev reviewed Nov 18, 2022

View reviewed changes

MailAlert.php Outdated Show resolved Hide resolved

marsaldev added enhancement waiting for author Waiting for author labels Nov 29, 2022

marsaldev reviewed Nov 29, 2022

View reviewed changes

upgrade/upgrade-2.3.4.php Outdated Show resolved Hide resolved

marsaldev reviewed Nov 29, 2022

View reviewed changes

MailAlert.php Outdated Show resolved Hide resolved

Hlavtox modified the milestones: 2.4.1, 2.4.2 Mar 23, 2023

MatShir removed the waiting for author Waiting for author label Jun 15, 2023

LouisAUTHIE previously approved these changes Aug 4, 2023

View reviewed changes

lmeyer1 added 7 commits August 11, 2023 16:30

Save create and update time for oos notifications

9bbf520

soft delete and save date when notification was sent

87de397

fix indents

cd227fe

fix phpstan

94ed101

Keep date_upd consistent

94c1c55

Update PR after publication of v. 2.4.1

9eadfd2

fix typo in query

0f76822

lmeyer1 dismissed LouisAUTHIE’s stale review via 0f76822 August 11, 2023 14:33

lmeyer1 force-pushed the feat-db branch from 06d37ce to 0f76822 Compare August 11, 2023 14:33

matks removed this from the 2.4.2 milestone Sep 27, 2023

Touxten closed this Jan 15, 2026

github-project-automation bot moved this from Ready for review to Closed in PR Dashboard Jan 15, 2026

Touxten reopened this Jan 15, 2026

github-project-automation bot moved this from Closed to Reopened in PR Dashboard Jan 15, 2026

Touxten added this to the 3.0.2 milestone Jan 15, 2026

Touxten added 2 commits January 20, 2026 07:45

Update and rename upgrade-2.4.2.php to upgrade-4.0.0.php

e59d48b

Update php.yml cache 2 to 4

f59d7da

jf-viguier previously approved these changes Jan 20, 2026

View reviewed changes

Update php.yml

3f8aa84

lmeyer1 dismissed jf-viguier’s stale review via 3f8aa84 January 28, 2026 16:05


		/** @var string Object last modification date */
		public $date_upd;

Conversation

lmeyer1 commented Nov 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marsaldev commented Nov 18, 2022

Uh oh!

lmeyer1 commented Nov 18, 2022

Uh oh!

Uh oh!

Uh oh!

marsaldev commented Nov 29, 2022

Uh oh!

jf-viguier commented Aug 4, 2023

Uh oh!

LouisAUTHIE left a comment

Choose a reason for hiding this comment

Uh oh!

LouisAUTHIE commented Aug 4, 2023

Uh oh!

souvrard commented Aug 9, 2023

Uh oh!

lmeyer1 commented Aug 11, 2023

Uh oh!

jf-viguier Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

jf-viguier Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

jf-viguier Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants