Skip to content

Fix checkout step navigation and CTAs for virtual-only carts#949

Open
tblivet wants to merge 3 commits intoPrestaShop:2.xfrom
tblivet:fix/checkout-button-step
Open

Fix checkout step navigation and CTAs for virtual-only carts#949
tblivet wants to merge 3 commits intoPrestaShop:2.xfrom
tblivet:fix/checkout-button-step

Conversation

@tblivet
Copy link
Contributor

@tblivet tblivet commented Mar 5, 2026

Questions Answers
Description? Fix checkout step navigation and CTAs for virtual-only carts
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? #948
Sponsor company @PrestaShopCorp
How to test? Follow the issue :)

@tblivet tblivet added this to the v2.0.1 milestone Mar 5, 2026
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Mar 5, 2026
@tblivet tblivet linked an issue Mar 5, 2026 that may be closed by this pull request
2 tasks
@tblivet tblivet requested review from Hlavtox and ga-devfront March 5, 2026 11:24
Quetzacoalt91
Quetzacoalt91 previously approved these changes Mar 5, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Mar 5, 2026
@ingridusta ingridusta self-assigned this Mar 5, 2026
Copy link

@ingridusta ingridusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tblivet,

I detected a bug with your fix on phone screen as the stepper component is not the same :

Enregistrement.de.l.ecran.2026-03-05.a.16.14.00.mov

Next step displayed is "Shipping method" but should be Payment.

@ps-jarvis
Copy link

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Shop.Theme.Actions
    • Back to Shipping

(Note: this is an automated message, but answering it will reach a real human)

Quetzacoalt91
Quetzacoalt91 previously approved these changes Mar 5, 2026
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a best solution would be to use just “Next”/“Continue” and “Back”.

Because there can be another checkout steps added or some removed via checkout hooks. We cannot be entirely sure if the next/previous step is delivery for example.

@tblivet
Copy link
Contributor Author

tblivet commented Mar 6, 2026

Hi @Hlavtox!

Yes, the steps seem quite hardcoded here, unfortunately. For now, we should probably go with it, as this section could be refactored in the future. We already have a contributor who opened an issue about this topic (#719), which could be improved to better fit the PrestaShop architecture. What do you think?

Copy link

@ingridusta ingridusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tblivet !

I tested your pr and it fixes the original bug detected.

Cart 1 : physical product

Laptop device

laptop.device.physical.product.mov

Mobile device

mobile.device.physical.product.mov

Cart 2 : physical product + virtual product

Laptop device

laptop.device.physical.product.+.virtual.product.mov

Mobile device

mobile.device.physical.product.+.virtual.product.mov

Cart 3 : virtual product

Laptop device

laptop.device.virtual.product.mov

Mobile device

mobile.device.virtual.product.mov

It's approved for QA's side. What do you think @Hlavtox ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.

[BUG] Unlogical checkout steps CTA

6 participants