ContactForm: Hide subject dropdown when only one contact is available#932
Merged
Touxten merged 2 commits intoPrestaShop:2.xfrom Feb 17, 2026
Merged
Conversation
Touxten
previously approved these changes
Feb 12, 2026
tblivet
requested changes
Feb 12, 2026
Contributor
tblivet
left a comment
tblivet
left a comment
There was a problem hiding this comment.
Hi @Codencode, thanks for the PR just a few changes and I think you should target the 2.x branch 👍
Codencode
force-pushed
the
contactform-hide-subject-when-single-contact
branch
from
56ba249 to
dfea5fe
Compare
Contributor
Author
|
I switched branch and added the escape statement, but I can't change the code to retrieve the single contact, because $contact uses id_contact as indices, that's why I use |
Codencode
force-pushed
the
contactform-hide-subject-when-single-contact
branch
from
dfea5fe to
96d8ea3
Compare
Codencode
force-pushed
the
contactform-hide-subject-when-single-contact
branch
from
96d8ea3 to
d34ea3f
Compare
tblivet
requested changes
Feb 13, 2026
Codencode
force-pushed
the
contactform-hide-subject-when-single-contact
branch
from
d34ea3f to
88f392a
Compare
Touxten
approved these changes
Feb 13, 2026
ingridusta
approved these changes
Feb 17, 2026
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @Codencode,
I tested your pr and it works as expected. When 1 contact only remains, heading 'Subject' is not displayed anymore.
I also created back contacts, and heading 'Subject' is displayed back.
Thanks, it's QA approved !
Contributor
Author
|
@tblivet can I merge this PR? Or should we wait for the module PR to be merged first? |
Contributor
|
@Codencode I think this can be merged 👍 |
Contributor
|
Thank you @Codencode && @tblivet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of rendering a
<select>with a single option, the module now automatically sets theid_contactvalue using a hidden input.This improves the user experience by removing an unnecessary selection while preserving the expected form behavior.
- Delete the contacts, leaving only one
- In the front office, go to the Contact page
- The
Subject Headinglabel and its related select dropdown should not be displayedBefore
After