Provide absolute URL to fix routing issues#61
Merged
Quetzacoalt91 merged 3 commits intoPrestaShop:devfrom Oct 30, 2025
Merged
Conversation
Contributor
Hlavtox
commented
Jul 25, 2025
| Questions | Answers |
|---|---|
| Description? | Provide absolute URL to fix routing issues. Fixes potential issues coming from relative URLs not being reliable after symfony migration. See PrestaShop/PrestaShop#39185. cc @Touxten |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#39185 |
| Sponsor company | TRENDO s.r.o. |
| How to test? | Just test the module can be configured correctly and loads in the backoffice, so we didn't break anything or have some typo. (On nginx server, this could be problematic.) |
Touxten
approved these changes
Jul 25, 2025
ShaiMagal
approved these changes
Jul 25, 2025
boherm
approved these changes
Aug 12, 2025
Contributor
Author
|
@PrestaShop/qa-functional This can be tested normally, doesnt need developer time to test if configuration form works. |
Contributor
Author
|
Ping @PrestaShop/qa-functional @PrestaShop/committers for QA, this is required for this module to work on 9.0.x branch on NGINX. |
Codencode
approved these changes
Oct 8, 2025
Nakahiru
approved these changes
Oct 27, 2025
Member
|
Hi there, I've deployed a shop on PrestaShop 9.1 with PHP-FPM and Nginx based on this configuration, @SiraDIOP it may help you for the next tests: Files to use to deploy PrestaShop with Nginxdocker-compose.ymlservices:
mysql:
image: mariadb:10.3.39
ports:
- "3306"
volumes:
- dbdata:/var/lib/mysql
- ./config-files/mysql/conf.d/:/etc/mysql/conf.d
environment:
MYSQL_ROOT_PASSWORD: MyEpicPassword
MYSQL_DATABASE: psreference
php:
image: prestashop/prestashop:9-fpm
expose:
- "9000"
depends_on:
- mysql
environment:
DB_SERVER: mysql
DB_PASSWD: MyEpicPassword
DB_NAME: psreference
PS_DOMAIN: localhost:8002
PS_INSTALL_AUTO: 1
PS_ERASE_DB: 1
PS_INSTALL_DB: 1
PS_FOLDER_ADMIN: admin-dev
PS_FOLDER_INSTALL: install-dev
PS_DEV_MODE: 1
DB_PREFIX: ks_
# PS_LANGUAGE: fr
# PS_COUNTRY: FR
volumes:
- temp-ps:/var/www/html
nginx:
image: nginx
ports:
- "8002:80"
- "443"
depends_on:
- php
volumes:
- temp-ps:/var/www/html
- ./config-files/nginx/conf.d/:/etc/nginx/conf.d
volumes:
dbdata:
temp-ps:config-files/nginx/conf.d/:/etc/nginx/conf.dResultsCurrent behavior (
|
Quetzacoalt91
requested changes
Oct 29, 2025
Contributor
Author
|
@Quetzacoalt91 Should be good now! |
Poulinhoo
approved these changes
Oct 29, 2025
Nakahiru
approved these changes
Oct 30, 2025
Quetzacoalt91
approved these changes
Oct 30, 2025
|
Hello @Hlavtox, Thanks for your PR, I tested it and i follow the how to test with nginx and it's good for me Thanks |
SiraDIOP
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.