Conversation
| @@ -1,23 +1,9 @@ | |||
| FROM golang:1.13-alpine as builder | |||
There was a problem hiding this comment.
I understand the removal of this section due to the build script but I like the idea of keeping this part in there for other folks to have a nice way of building locally without having to run the full buildDocker.sh script.
There was a problem hiding this comment.
This new version also requires you to build the binaries ahead of the Docker file which works fine for the pipeline but now forces people into a 2-step process when building locally.
| tags: true | ||
| - provider: script | ||
| script: bash scripts/publish_docker.sh ${TRAVIS_BRANCH} | ||
| script: bash scripts/publish_docker.sh ${TRAVIS_BRANCH} true |
There was a problem hiding this comment.
Looks like publish_docker.sh was deleted?
| echo "---------------------" | ||
|
|
||
| docker run --rm -v "$PWD":/go/va -w /go/va golang:1.13-alpine \ | ||
| sh -c "apk add bash zip && ./build.sh ${VERSION} linux" |
There was a problem hiding this comment.
Any reason to call apk add bash zip twice here? Also, that means this script will only work on alpine machines (can't run this file on other flavors or macos)?
| @@ -0,0 +1,14 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I like this file broken out so we can all build consistently.
| cd bin | ||
| cp vadmin-${GOOS} vadmin | ||
| zip vadmin-${GOOS}-${VERSION}.zip vadmin | ||
| rm vadmin |
There was a problem hiding this comment.
Maybe leave the binary for local dev?
2 participants
@thorix this includes your changes for 1.13