Expand test suite #787
Open
Expand test suite #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR expands the automated test suite with large file transfer scenarios, explicit pty-allocation toggles, and default shell configuration tests, and refactors the build tooling to ensure Cygwin is installed before running Pester tests.
- Add Terminal.Tests.ps1 for interactive pty-allocation test scaffolding
- Extend SSH, SFTP, and SCP tests with large file transfers and default shell configuration contexts
- Refactor AzDOBuildTools.psm1 to install Cygwin before running E2E tests
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| regress/pesterTests/Terminal.Tests.ps1 | New interactive terminal allocation test |
| regress/pesterTests/SSH.Tests.ps1 | Add “disable pseudo-terminal allocation (-T)” test |
| regress/pesterTests/SFTP.Tests.ps1 | Introduce large-file tests and default shell setup |
| regress/pesterTests/SCP.Tests.ps1 | Add large-file SCP tests and default shell configuration |
| contrib/win32/openssh/AzDOBuildTools/AzDOBuildTools.psm1 | Reorder E2E test invocation after Cygwin check and installation |
Comments suppressed due to low confidence (3)
regress/pesterTests/SFTP.Tests.ps1:162
- [nitpick] Property key casing is inconsistent with earlier
ExpectedOutput; use a uniform name (ExpectedOutput) for clarity.
expectedoutput = (join-path $serverdirectory $largeFileName)
regress/pesterTests/SCP.Tests.ps1:213
- The large file created for tests (
$largeFilePath) isn't removed inAfterAll, leading to orphaned files; add cleanup.
AfterAll {
contrib/win32/openssh/AzDOBuildTools/AzDOBuildTools.psm1:255
- The string interpolation with nested double quotes will break parsing; use
$($OpenSSHTestInfo["E2ETestResultsFile"])or escape the inner quotes.
Write-BuildMessage -Message "Test result file $OpenSSHTestInfo["E2ETestResultsFile"] not found after tests." -Category Error
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
SCP.tests.ps1andSFTP.Tests.ps1with large file transfer and default shell testsSSH.tests.ps1with explicit test for disabling pty-allocationTerminal.Tests.ps1intended to run from interactive terminal (and skipped during CI) for pty-allocation test (and eventually more terminal tests).PR Context