Skip to content

fix: "posting to" showing when there are no feed distributors#182

Merged
elliotBraem merged 1 commit intomainfrom
fix/hide-posting-to-when-not-needed
Jun 20, 2025
Merged

fix: "posting to" showing when there are no feed distributors#182
elliotBraem merged 1 commit intomainfrom
fix/hide-posting-to-when-not-needed

Conversation

@itexpert120
Copy link
Collaborator

@itexpert120 itexpert120 commented Jun 20, 2025

Showing for feeds with posting to distributors
image

Not showing for feeds with no distributors
image

Summary by CodeRabbit

  • New Features

    • Introduced a new component for displaying distributor badges in the feed layout.
  • Refactor

    • Improved the feed layout by encapsulating badge rendering into a reusable component for better maintainability and consistency.

@vercel
Copy link

vercel bot commented Jun 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curatedotfun-app 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 8:41pm

@coderabbitai
Copy link

coderabbitai bot commented Jun 20, 2025

Walkthrough

A new DistributorBadges React component was introduced to encapsulate the logic for rendering distributor badges. The feed layout file was updated to use this new component, replacing the previous inline badge rendering logic with a cleaner, component-based approach.

Changes

File(s) Change Summary
apps/app/src/components/DistributorBadges.tsx Added new DistributorBadges component to render distributor badges from a provided array.
apps/app/src/routes/_layout/feed/$feedId.tsx Replaced inline badge rendering with the new DistributorBadges component and updated imports.

Sequence Diagram(s)

sequenceDiagram
    participant FeedLayout
    participant DistributorBadges

    FeedLayout->>DistributorBadges: Pass distribute array as prop
    DistributorBadges->>DistributorBadges: Render badges for each plugin
    DistributorBadges-->>FeedLayout: Rendered badge elements
Loading

Poem

In the meadow of code where the badges now play,
A new bunny arrived to brighten the day.
DistributorBadges hops in, neat and spry,
Tidying up badges as feeds flutter by.
With a twitch of the nose and a hop so light,
The code is now cleaner—oh, what a sight! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/app/src/components/DistributorBadges.tsx (1)

12-12: Consider adding null safety for plugin property.

While the current usage might guarantee plugin existence, adding optional chaining would make the component more robust against potential undefined values.

-        const pluginName = distributor.plugin.replace("@curatedotfun/", "");
+        const pluginName = distributor.plugin?.replace("@curatedotfun/", "") || "";
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6811463 and 4a4dd88.

📒 Files selected for processing (2)
  • apps/app/src/components/DistributorBadges.tsx (1 hunks)
  • apps/app/src/routes/_layout/feed/$feedId.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Run Tests
🔇 Additional comments (3)
apps/app/src/components/DistributorBadges.tsx (1)

1-24: LGTM! Clean component structure that addresses the PR objective.

The component is well-structured and correctly handles the plugin name transformation. The conditional rendering logic in the parent component ensures "Posting to:" only appears when distributors exist, which aligns perfectly with the PR objective.

apps/app/src/routes/_layout/feed/$feedId.tsx (2)

6-6: LGTM! Import statement correctly added.

The import path is correct and follows the established import pattern in the file.


98-104: Excellent implementation that solves the PR objective.

The conditional rendering logic correctly ensures that "Posting to:" text only appears when there are distributors (length > 0). The null safety with optional chaining and nullish coalescing (??) prevents runtime errors. This refactoring successfully addresses the issue described in the PR objectives.

@elliotBraem elliotBraem merged commit 4363b53 into main Jun 20, 2025
3 of 5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants