Skip to content

fix: forward groups and group_properties to evaluate_all_flags#109

Merged
patricio-posthog merged 3 commits intomainfrom
fix/evaluate-all-flags-signature
May 5, 2026
Merged

fix: forward groups and group_properties to evaluate_all_flags#109
patricio-posthog merged 3 commits intomainfrom
fix/evaluate-all-flags-signature

Conversation

@patricio-posthog
Copy link
Copy Markdown
Contributor

Motivation and Context

The release pipeline for v0.7.0 failed because Client::evaluate_flags (added in #105) calls LocalEvaluator::evaluate_all_flags with the old 2-argument signature, while #107 changed that method to require groups and group_properties as well.

The two PRs didn't conflict textually — different files, non-overlapping diffs — so neither PR's CI caught the type-level incompatibility. The repo doesn't run CI on push: main, so the failure surfaced only at release time when cargo publish --dry-run tried to compile the published tarball.

Fix

EvaluateFlagsOptions already carries groups and group_properties. Forward them through to evaluate_all_flags from both the async and blocking clients.

How did you test it?

  • cargo build clean
  • cargo build --features e2e-test clean (this is the path that fails in the release pipeline)
  • cargo test — all 119 tests pass
  • cargo clippy --all-targets clean

Follow-up worth considering

To prevent this class of bug, the repo could add either:

  • A required "branch up-to-date with main" rule on PRs (forces a rebase, which would have surfaced the type error before merge).
  • A push: main build job mirroring the PR build (would catch incompatibilities post-merge before release).

@patricio-posthog patricio-posthog requested a review from a team as a code owner May 5, 2026 12:40
@marandaneto
Copy link
Copy Markdown
Member

rollback this commit dfa3b3b so we can publish that version again

@patricio-posthog patricio-posthog merged commit db601db into main May 5, 2026
11 checks passed
@patricio-posthog patricio-posthog deleted the fix/evaluate-all-flags-signature branch May 5, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants