fix: forward groups and group_properties to evaluate_all_flags#109
Merged
patricio-posthog merged 3 commits intomainfrom May 5, 2026
Merged
fix: forward groups and group_properties to evaluate_all_flags#109patricio-posthog merged 3 commits intomainfrom
patricio-posthog merged 3 commits intomainfrom
Conversation
Member
|
rollback this commit dfa3b3b so we can publish that version again |
marandaneto
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The release pipeline for v0.7.0 failed because
Client::evaluate_flags(added in #105) callsLocalEvaluator::evaluate_all_flagswith the old 2-argument signature, while #107 changed that method to requiregroupsandgroup_propertiesas well.The two PRs didn't conflict textually — different files, non-overlapping diffs — so neither PR's CI caught the type-level incompatibility. The repo doesn't run CI on
push: main, so the failure surfaced only at release time whencargo publish --dry-runtried to compile the published tarball.Fix
EvaluateFlagsOptionsalready carriesgroupsandgroup_properties. Forward them through toevaluate_all_flagsfrom both the async and blocking clients.How did you test it?
cargo buildcleancargo build --features e2e-testclean (this is the path that fails in the release pipeline)cargo test— all 119 tests passcargo clippy --all-targetscleanFollow-up worth considering
To prevent this class of bug, the repo could add either:
main" rule on PRs (forces a rebase, which would have surfaced the type error before merge).push: mainbuild job mirroring the PR build (would catch incompatibilities post-merge before release).