feat: disable or enable session replay plugins based on remote config #452
Conversation
| /// | ||
| /// // Token automatically unsubscribes when deallocated | ||
| /// ``` | ||
| final class MulticastCallback<T> { |
There was a problem hiding this comment.
This is a generalized pattern already used in the codebase. Did not refactor existing code to keep the scope small for this PR, but will do with a future PR
| if let isEnabled = capturePerformanceValue as? Bool { | ||
| return isEnabled | ||
| } | ||
| // When enabled, capturePerformance is an object (we ignore the keys for now) |
There was a problem hiding this comment.
which configs are within the capturePerformance config?
|
|
||
| if let index = installedIndex, !isEnabled { | ||
| // Installed, but disabled in remote | ||
| installedPlugins[index].stop() |
There was a problem hiding this comment.
Should we check that installedPlugins has the index (index) and the same for remove to avoid out-of-bounds issues?
| /// | ||
| /// // Token automatically unsubscribes when deallocated | ||
| /// ``` | ||
| final class MulticastCallback<T> { |
There was a problem hiding this comment.
should we call it PostHogMulticastCallback to avoid naming clashes with other things?
| let config = URLSessionConfiguration.default | ||
|
|
||
| #if DEBUG | ||
| config.requestCachePolicy = .reloadIgnoringLocalCacheData |
marandaneto
left a comment
marandaneto
left a comment
There was a problem hiding this comment.
left a few comments but LGTM
the project settings FE would require a few changes since this is now supported on the ios sdk now, and most likely indirectly for rn ios and flutter ios
💡 Motivation and Context
Closes #351
Adds the ability to enable/disable session replay plugins via PostHog project settings.
The current configs options affected are
sessionReplayConfig.captureLogs(key sessionRecording.consoleLogRecordingEnabled)sessionReplayConfig.captureNetworkTelemetry(key capturePerformance)Local config takes precedence. A plugin must first be enabled locally before remote config is evaluated.
Limitations / Future work
config.remoteConfig = true./flags?config=trueresponse as a fallback whenconfig.remoteConfig = false💚 How did you test it?
📝 Checklist