Skip to content

Rewrite porklib:graphics#35

Merged
DaMatrix merged 25 commits intodevelopmentfrom
dev/graphics-rewrite
Jan 30, 2020
Merged

Rewrite porklib:graphics#35
DaMatrix merged 25 commits intodevelopmentfrom
dev/graphics-rewrite

Conversation

@DaMatrix
Copy link
Member

porklib:graphics is a bit of a mess I threw together as an afterthought while making porklib:gui earlier this year. I'm going to completely rewrite it in a more logical way, and add a number of features such as a superior image encoding/decoding API than ImageIO.

we really don't need totally separate implementations for every color format, since everything has to be converted to ARGB to be used by bufferedimage in the end anyway i'll just let bitmap implementations handle ARGB conversions themselves
it won't though, because a) my interpolation code is crap and b) i have no time
somehow getting colors is totally broken, gonna have to investigate that
okay boilerplate should be mostly done now
this would allow to avoid useless memory copies when all you need is an immutable view of a mutable image
@DaMatrix DaMatrix marked this pull request as ready for review January 30, 2020 12:09
@DaMatrix DaMatrix changed the title [WIP] Rewrite porklib:graphics Rewrite porklib:graphics Jan 30, 2020
@DaMatrix
Copy link
Member Author

This turned into more of a refactor of PImage and making it not inherit PIcon. This is really enough for now, actual image encoding stuff can come later (once I've decided how best to implement compression in #38).

@DaMatrix DaMatrix merged commit 65d0934 into development Jan 30, 2020
@DaMatrix DaMatrix deleted the dev/graphics-rewrite branch January 30, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant