Open
Conversation
i really need to refactor this whole module at some point
not sure how i missed the alert one, that never should have worked...
users can implement it themselves if they really need it
the entire rest of porklib is unsafe, so why should those particular classes not be?
when you make a channel of a channel it will just keep the name you have given to it without any indication that it was a channel of a channel. This Pull request appends the original name of the channel so it is visible in the log what kind of channel the message came from
channelled Logger
cherry-picked from commit 84b994c
DaMatrix
force-pushed
the
development
branch
from
acbd19d to
0e3f842
Compare
DaMatrix
force-pushed
the
development
branch
from
0e3f842 to
c836109
Compare
DaMatrix
force-pushed
the
development
branch
from
0d954a4 to
1f208bf
Compare
also clean up PUnsafe and first half of PArrays
this reduces some wasted memory caused by object alignment
that's a lot of extra code for very little benefit
this avoids an extra ByteBuffer allocation in most cases
…compressor these functions aren't possible to implement efficiently for arbitrary compression algorithms
now it's consistent with the libdeflate bindings
this has been replaced by :deflate, which is much better
how the hell did i never notice this was completely broken???
also remove some other unsafe direct buffer functions which were kinda useless
now there will be no more faffing about with different toolchains being installed on different platforms
also delete the old common code which is no longer being used anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the old pr (#10) was lost when i eradicated the primitive source from the git log, so i need a new one lol