fix: 🐛 prefer native WebSocket in assertExpectedChainVersion for Workers #1609
Open
prashantasdeveloper wants to merge 2 commits into
Open
fix: 🐛 prefer native WebSocket in assertExpectedChainVersion for Workers #1609prashantasdeveloper wants to merge 2 commits into
prashantasdeveloper wants to merge 2 commits into
Conversation
Cloudflare Workers with nodejs_compat expose both globalThis.WebSocket and process.versions.node, which caused the SDK to dynamically import the Node ws package and fail with "ws does not work in the browser". Prefer the native WebSocket whenever it exists and only fall back to ws when it does not.
updateStatus only notified listeners for Unapproved, Running, and Succeeded, so intermediate states like Future and InBlock were skipped. Include those statuses (and Idle) in the StatusChange event path
|
F-OBrien
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
JIRA Link
Checklist