Small api fixes#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces two small API/interop improvements in the BP module: it adds a Serde deserialization alias for AssetKeys::enc_keys and adds sqlx BLOB encoding/decoding support for AccountPublicKeys so it can be stored/loaded via SQLx-backed persistence.
Changes:
- Add Serde alias
encKeysfor theenc_keysfield inAssetKeys. - Add
sqlx::Type,sqlx::Decode, andsqlx::Encodeimplementations forAccountPublicKeysusing BLOB storage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/bp/sqlx_impl.rs |
Adds SQLx Type/Decode/Encode impls for AccountPublicKeys stored as a BLOB. |
src/bp/asset.rs |
Adds a Serde alias for AssetKeys::enc_keys to accept encKeys on deserialize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lovesh
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enc_keysfield.AccountPublicKeys.