Skip to content

handle generators refs and input validation#1

Merged
Neopallium merged 3 commits into
polymeshfrom
patch4
May 3, 2026
Merged

handle generators refs and input validation#1
Neopallium merged 3 commits into
polymeshfrom
patch4

Conversation

@lovesh

@lovesh lovesh commented May 1, 2026

Copy link
Copy Markdown

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Neopallium Neopallium left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some more panicky code.

Comment thread relations/src/ped_comm_group_elems.rs Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread relations/src/ped_comm_group_elems.rs Outdated
Comment thread relations/src/ped_comm_group_elems.rs Outdated
Comment thread ark-dlog-gadget/src/dlog.rs Outdated
Comment thread .github/workflows/build-and-test.yml Outdated
lovesh and others added 2 commits May 2, 2026 02:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@Neopallium Neopallium left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still more panicky code that needs to be converted to errors.

@Neopallium

Copy link
Copy Markdown
Collaborator

Merging since this fixes a lot of panicky code.

@Neopallium Neopallium merged commit ec4e07f into polymesh May 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants