-
Notifications
You must be signed in to change notification settings - Fork 133
Refactor a bunch of old APIs, add some new APIs, and add fallback addon #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I don't think that we will have higher-order types with more than 2 parameters, so I only made K and K2
|
I have no idea why the CI is failing, I looked briefly and it was something about javadocs, I will investigate this later |
|
As I go i am also refactoring any getters I encounter to record-style getters. ( |
it's bc you have a few instances of like |
This does a whole bunch of stuff, at this point it's basically "dfsek's original 7.0 ideas lite"
Let me know if there are any specific things you want me to revert.
So far we have:
OptionalwithMaybeto play nice with new APIs.manifest-addon-loader->addon-loader-manifestapi-addon-loader->addon-loader-apipalette-block-shortcut->shortcut-block-palettestructure-block-shortcut->shortcut-block-structurelibrary-image->api-imagebiome-query-api->api-biome-queryLazy(refactored toMemo) is now aMonad, lazy in all monad and functor operationsPairis now a BiFunctor, and refactored a bunch of static methods operating onPairto generic versions on anyBiFunctorThere will probably be more things that I may or may not remember to add to this comment :)