Skip to content

Align gen-plan AC contract with RLCR review#160

Open
Buyi-wsgzg wants to merge 1 commit into
PolyArch:devfrom
Buyi-wsgzg:fix/gen-plan-current-scope-ac-contract
Open

Align gen-plan AC contract with RLCR review#160
Buyi-wsgzg wants to merge 1 commit into
PolyArch:devfrom
Buyi-wsgzg:fix/gen-plan-current-scope-ac-contract

Conversation

@Buyi-wsgzg
Copy link
Copy Markdown

Summary

  • define AC-* as current RLCR completion gates in gen-plan templates and
    workflow rules
  • add a handoff AC pattern plus FUT-* future-work structure for deferred
    work
  • clarify RLCR reviewer prompts so future/out-of-scope items do not block
    COMPLETE
  • add static tests covering the new AC/FUT contract

Tests

  • bash tests/test-gen-plan.sh
  • bash tests/test-template-references.sh
  • bash tests/test-templates-comprehensive.sh
  • bash tests/test-style-compliance.sh
  • git diff --check

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff92a53d96

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +26 to +30
### Handoff AC Pattern

Use this pattern only when the draft contains a legitimate future goal that must be preserved without making it part of the current RLCR completion gate.

- AC-X: Handoff for <future goal> is complete without performing the future work.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the handoff pattern outside acceptance criteria

When the generated plan retains this instructional block, it lives under ## Acceptance Criteria, so RLCR setup/review will treat it as part of the current completion gate: Phase 2 copies this template into the output plan, and the new reviewer prompts define everything under Acceptance Criteria as in scope. The block also contains the new deferral keywords (future, FUT-*, without performing the future work), so plans with no intended future work can be flagged as having deferred/incomplete AC content unless Claude happens to delete or relocate this template text.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant