Harvest items compatibility changes#1270
Open
HoundAkragth wants to merge 1 commit intoPokecube-Development:1.21.1from
Open
Harvest items compatibility changes#1270HoundAkragth wants to merge 1 commit intoPokecube-Development:1.21.1from
HoundAkragth wants to merge 1 commit intoPokecube-Development:1.21.1from
Conversation
Modified the IHarvester to have an isAvailable function and then used it for checking if the item was gatherable in hasStuff. This allows mod compatibility to write a new IHarvester and register it instead of being blocked at the hasStuff, as if the item is listed the harvest_extra tag, that will just use the default harvest function which may be undesirable. Moved the drop list to be retrieved before the block is broken, as in some cases the block will drop nothing, likely because the block will be air.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the IHarvester to have an isAvailable function and then used it for checking if the item was gatherable in hasStuff. This allows mod compatibility to write a new IHarvester and register it instead of being blocked at the hasStuff, as if the item is listed in the harvest_extra tag right now, that will just use the default harvest function which may be undesirable.
Moved the drop list to be retrieved before the block is broken, as in some cases the block will drop nothing, likely because the block will be air.