Open
Conversation
rocco8773
reviewed
Jul 13, 2022
|
Test |
Member
|
@cmoissar let's see if this works |
Member
|
This is another test for the notification settings! |
|
Test the second! |
Co-authored-by: Erik Everson <eteverson@gmail.com>
namurphy
approved these changes
Jul 15, 2022
Member
namurphy
left a comment
namurphy
left a comment
There was a problem hiding this comment.
Thank you for adding this! It looks really useful.
Contributor
Author
|
So... Once such a pull request has been approved (which I don't think it would be in its current state - were this repo other than a playing ground for training purposes), what happens next? For example, I cannot see this file in PlasmaPy/hack-week/Hack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote another ionisation function - which is a light weight fit of the result from the "full" Thomas-Fermi model.