Do the decompression and the chunk creation in one Task#2973
Merged
IntegratedQuantum merged 2 commits intoPixelGuys:masterfrom Apr 26, 2026
Merged
Conversation
Wunka
suggested changes
Apr 24, 2026
Contributor
Wunka
left a comment
Wunka
left a comment
There was a problem hiding this comment.
The Github UI suggests me as a reviewer so here is my review.
| .wy = try reader.readInt(i32), | ||
| .wz = try reader.readInt(i32), | ||
| .voxelSize = try reader.readInt(u31), | ||
| const task = main.globalAllocator.create(MeshGenerationTask); |
Contributor
There was a problem hiding this comment.
Suggested change
| const task = main.globalAllocator.create(MeshGenerationTask); | |
| const task = main.globalAllocator.create(MeshGenerationTask); | |
| errdefer main.globalAllocator.destroy(task); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progress towards #2972
No measurable performance improvement was found