Skip to content

Added TotalDemented's Songs#23

Merged
IntegratedQuantum merged 3 commits intoPixelGuys:masterfrom
ikabod-kee:xzxxxx
Apr 26, 2026
Merged

Added TotalDemented's Songs#23
IntegratedQuantum merged 3 commits intoPixelGuys:masterfrom
ikabod-kee:xzxxxx

Conversation

@ikabod-kee
Copy link
Copy Markdown
Contributor

It looks like two were removed, but they were actually renamed.

@ikabod-kee ikabod-kee moved this to Waiting for artistic review in PRs to review Mar 23, 2026
Copy link
Copy Markdown

@careeoki careeoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I listened to all of these the the music test, they are good.

@ikabod-kee ikabod-kee moved this from Waiting for artistic review to Easy to Review in PRs to review Mar 23, 2026
Copy link
Copy Markdown
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, for documentation purpose, could you also roughly describe the scenarios we want them to be in?

Comment thread music/totaldemented/root.ogg
@ikabod-kee
Copy link
Copy Markdown
Contributor Author

Adventurous:

  • Exploration song.

Cubyz:

  • Previously the title theme, is now used as a placeholder.

Filled with Love:

  • Upbeat exploration song.

Frigid Feeling:

  • Exploration song that plays in cold biomes.

Hypoxia:

  • Exploration song that plays in barren biomes.

In the Depths:

  • Song that plays very deep in the caves.

Leaves:

  • Song that plays in forests.

Looking Up:

  • Exploration song that plays while in high altitudes.

Midnight Melody:

  • Exploration song that plays during night.

Mycelia:

  • Song that plays in Mushroom Caves.

Root:

  • Ambient addon to the Root

Scoria:

  • Song that plays in hot cave biomes.

Sense of Wonder:

  • Exploration song that plays while in high altitudes.

Tides:

  • Beach-side song.

Tides Remix:

  • Warm ocean song.

Vitreous:

  • Deep-ish cave song.

@careeoki
Copy link
Copy Markdown

I wonder if we should start adding tags to songs now (like proposed here PixelGuys/Cubyz#732 (comment)) so it would be faster to add the new music system later.

@IntegratedQuantum
Copy link
Copy Markdown
Member

Yeah, that would be helpful

@careeoki
Copy link
Copy Markdown

How should we format it then?

@IntegratedQuantum
Copy link
Copy Markdown
Member

I'd say as a zon with the same name next to the file itself. In there just a tags field with all the tags you want.

@careeoki
Copy link
Copy Markdown

Alright, so adventurous.zig.zon would be something like this:

.{
	.tags = .{
		.serious,
		.mountain,
		.temperate,
		.cold,
		.day,
		.night,
	},
}

@IntegratedQuantum
Copy link
Copy Markdown
Member

Yeah, something like that.

Comment thread music/totaldemented/root.ogg
@IntegratedQuantum IntegratedQuantum merged commit dad3425 into PixelGuys:master Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants