fix: resolve SC2157 and SC2034 ShellCheck findings#25
Merged
claude[bot] merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
- SC2157 (all 3): hoist GITHUB_ORG/GITHUB_DEFAULT_OWNER conditionals into _ws_org_line/_ws_owner_line variables before the WS_CONF heredoc, then interpolate variables inside it; output is byte-identical - SC2034 (xubuntu + fedora): remove unused END_MARKER variable (these scripts derive end_check dynamically via parameter expansion, unlike crostini) Closes #23 Co-authored-by: Christopher Jon Pitzi <cpitzi@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_ORG/GITHUB_DEFAULT_OWNERconditional logic into_ws_org_line/_ws_owner_linevariables before theWS_CONFheredoc, then interpolate them inside it. The config file output is byte-identical to before.END_MARKERvariable. These scripts deriveend_checkdynamically via${marker_check/>>>/<<<}parameter expansion;END_MARKERwas never referenced.shellcheck --severity=warning --shell=bashpasses on all three scripts.Closes #23
Generated with Claude Code