Open
Conversation
evaneus
reviewed
Feb 27, 2018
Contributor
evaneus
left a comment
evaneus
left a comment
There was a problem hiding this comment.
apart from some comments here, overall I'd like to look at this more closely and make some changes before merging.
| @@ -1,96 +1,36 @@ | |||
| # File Uploader | |||
| # Image Upload | |||
Contributor
There was a problem hiding this comment.
what about file uploads? Like a video file or audio file.
Member
Author
There was a problem hiding this comment.
we don't have it implemented right now, can we add it once it's implemented? maybe put in a coming soon? It'll be pretty similar to image upload.
| ``` | ||
|
|
||
|
|
||
| #### name (required) |
Contributor
There was a problem hiding this comment.
why removing these sections?
Member
Author
There was a problem hiding this comment.
I felt that it was just repeating what npm documents already, so not needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.