Skip to content

Conversation

@dyackzan
Copy link

@dyackzan dyackzan commented Apr 22, 2025

  • Fix submodule CMake to be able to build with debug & ninja mixins

Without this change my build fails if I try colcon build --mixin debug ninja

To test: make sure everything builds successfully with colcon build --mixin release ninja and colcon build --mixin debug ninja

@dyackzan dyackzan force-pushed the fix-covariance-geometry-ros-cmake branch from 195b798 to 004a901 Compare April 22, 2025 20:00
@henrygerardmoore
Copy link
Collaborator

What's up with

set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-inline -fno-inline-small-functions")

* Fix submodule CMake to enable colcon build with the ninja and debug
  mixins
@dyackzan dyackzan force-pushed the fix-covariance-geometry-ros-cmake branch from 004a901 to 56aef0b Compare April 22, 2025 20:15
@dyackzan
Copy link
Author

What's up with

set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-inline -fno-inline-small-functions")

Without that, the linking fails because of some missing symbols. This seems like the nonsense we dealt with earlier where it looks like some compiler optimization routine is removing symbols for something we end up needing

@dyackzan
Copy link
Author

dyackzan commented Apr 22, 2025

If it's too ugly I can look into a more elegant solution. Maybe a better way to do this would be to just add the covariance_geometry_cpp repo as a submodule inside of covariance_geometry_ros (rather than pulling it in via CMake FetchContent) and hope that the compiler will realize not to strip those symbols in that case

@dyackzan dyackzan merged commit ed092c1 into humble Apr 24, 2025
4 checks passed
@dyackzan dyackzan deleted the fix-covariance-geometry-ros-cmake branch April 24, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants