Skip to content

Conversation

@henrygerardmoore
Copy link
Collaborator

@henrygerardmoore henrygerardmoore commented Mar 13, 2025

This adds the ability to use multiple cameras and relevant documentation.

Also fixes the update rate not listening to configuration by changing the default tf timeout for the publisher to be inline with the other values of that parameter.

Copy link
Collaborator

@rlpratt12 rlpratt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! The only minor change I'd suggest is making pose_covariance a vector (of vectors) to match estimation_frames so that we can pass in a different covariance for each (camera) source.

@rlpratt12
Copy link
Collaborator

rlpratt12 commented Mar 18, 2025

Also, I think we need to fix the blowing up orientation covariance issue. I confirmed this only happens in this branch, and not on main:
image

@henrygerardmoore
Copy link
Collaborator Author

Generally looks good! The only minor change I'd suggest is making pose_covariance a vector (of vectors) to match estimation_frames so that we can pass in a different covariance for each (camera) source.

Good point, I'll do that.

@henrygerardmoore
Copy link
Collaborator Author

Also, I think we need to fix the blowing up orientation covariance issue.

Will address this in a separate PR for that workspace

Copy link
Collaborator

@rlpratt12 rlpratt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrygerardmoore
Copy link
Collaborator Author

Tested on HW and this works well, so merging it

@henrygerardmoore henrygerardmoore merged commit f3693bf into humble Mar 21, 2025
4 checks passed
@henrygerardmoore henrygerardmoore deleted the multiple_cameras branch March 21, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants