Allow custom FPS values for each GameSpeed index by 11EJDE11 · Pull Request #2092 · Phobos-developers/Phobos

11EJDE11 · 2026-02-05T18:58:03Z

Deprecates CustomGS ini keys
Adds EnableCustomFPS and CustomGameSpeedFPS

Add to RulesMD.ini

;note: use 0 for the game's default fps for that index
[General]
EnableCustomFPS=True
CustomGameSpeedFPS.0=100
CustomGameSpeedFPS.1=90
CustomGameSpeedFPS.2=80
CustomGameSpeedFPS.3=70
CustomGameSpeedFPS.4=60
CustomGameSpeedFPS.5=0 ;default
CustomGameSpeedFPS.6=0 ;default

This PR allows for custom FPS values for each of the GameSpeed indices. Applies to Campaign, Skirmish, and Multiplayer.

For multiplayer we hook into Queue_AI_Multiplayer to override the hardcoded 60fps cap, and override the GameSpeed index to fps calculation.

For Skirmish and Campaign, we hook in main loop to set up the NFTTimer that is used in multiplayer. We then hook into SyncDelay and force skirmish/campaign down the multiplayer path instead.

github-actions · 2026-02-05T19:05:42Z

Nightly build for this pull request:

compiled-dll-ef98a0f12bf18daa12fdf29b0b12e6d59d04440b.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Metadorius · 2026-02-05T19:29:34Z

...did you just make teh game be able to run on any FPS online?

11EJDE11 · 2026-02-05T19:31:01Z

Yeah. I got up to 140fps LAN.

Metadorius · 2026-02-05T19:34:01Z

src/Misc/Hooks.Gamespeed.cpp

+struct NFTTimerStruct
 {
-	if (Phobos::Misc::CustomGS && SessionClass::IsSingleplayer())
-		FrameTimer.TimeLeft = GameOptionsClass::Instance.GameSpeed;
-	return 0;
-}
+	DWORD StartTime;
+	DWORD CurrentTime;
+	int   TimeLeft;
+};
+DEFINE_REFERENCE(NFTTimerStruct, NFTTimer, 0x887328);

-// note: currently vanilla code, doesn't do anything, changing PrecalcDesiredFrameRate doesn't effect anything either
-/*
-void SetNetworkFrameRate()
+struct FrameTimerStruct
 {
-	DEFINE_REFERENCE(int, PrecalcDesiredFrameRate, 0xA8B550u)
-	switch (GameOptionsClass::Instance.GameSpeed)
+	DWORD StartTime;
+	DWORD CurrentTime;
+	int   DelayTime;
+};
+DEFINE_REFERENCE(FrameTimerStruct, GameFrameTimer, 0x887348);


I think those may already exist in YRpp? There's some confusion with them there, maybe @ZivDero could help.

I'm not seeing them there. There's Timer.h but that looks more like something you'd create rather than use when accessing existing ones?

I think those may already exist in YRpp? There's some confusion with them there, maybe @ZivDero could help.

Well the structs at least exist at
https://github.com/Phobos-developers/YRpp/blob/7a43c8bc7872d81c27ce470a4f0bf4d1c3a8e224/Timer.h

The addresses don't seem to show up in YRpp so they're probably not in; Should be added there instead.
Their names are FrameTimer (from RA) and the other one we called NetworkFrameTimer.

CDTimerClass<SystemTimerClass> FrameTimer; CDTimerClass<MillisecondSystemTimerClass> NetworkFrameTimer;

CDTimerClass is what YRpp calls TimerStruct. SystemTimerClass is just SystemTimer.
MillisecondSystemTimerClass however is not present in YRpp it seems, and it is not the same as SystemTimerClass or MillisecondTimerClass.

I would provide the address but IDA isn't cooperating...

Starting at 5D5870, ctor, dtor, operator(), operator long

Thanks, Ziv. Can you please check Phobos-developers/YRpp#59

Metadorius · 2026-02-05T19:35:00Z

docs/Miscellanous.md


-Results (remember to replace N with your game speed number!):
+- Each of the 7 game speed slider positions (GameSpeed 0-6) can have a custom target FPS set independently. A value of `0` keeps that position at its vanilla FPS.
+- Works in skirmish, campaign, and multiplayer.


I think we should spell out explicitly that they will be unified now, so that the modders must disable the different game speed scales in client now.

Metadorius · 2026-02-05T19:38:48Z

docs/Miscellanous.md

-In `rulesmd.ini`:
-```ini
-[General]
-CustomGS=false              ; boolean
-CustomGSN.ChangeInterval=-1 ; integer >= 1
-CustomGSN.ChangeDelay=N     ; integer between 0 and 6
-CustomGSN.DefaultDelay=N    ; integer between 0 and 6
-; where N = 0, 1, 2, 3, 4, 5, 6
-```


should add migration entries to docs and the migration script (see FIXME entries)

b1e580f

Sorry, not seeing any FIXME?

Ctrl+F in migration script (see Phobos Supplementaries repo)

Thanks. Phobos-developers/PhobosSupplementaries#14

CnCRAZER · 2026-02-05T20:26:33Z

Yeah. I got up to 140fps LAN.

LOL

I love it!

tomsons26 · 2026-02-05T21:01:19Z

I speculate NFT is for NetworkFrameTimer btw

Update comments Update docs

11EJDE11 added 2 commits February 6, 2026 07:26

Allow custom FPS values for skirmish/campaign/multiplayer

3056067

Off by default

689967d

Metadorius reviewed Feb 5, 2026

View reviewed changes

Update docs

b1e580f

TaranDahl added ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable Needs MP testing This PR needs to be tested for desync. labels Feb 6, 2026

Use new YRpp defs

ed4de05

Update comments Update docs

Uh oh!

Conversation

11EJDE11 commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Metadorius commented Feb 5, 2026

Uh oh!

11EJDE11 commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CnCRAZER commented Feb 5, 2026

Uh oh!

tomsons26 commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

github-actions bot commented Feb 5, 2026 •

edited

Loading