Skip to content

Restored ScritType action 24 - Play speech with index... - #1900

Open
FS-21 wants to merge 5 commits into
Phobos-developers:developfrom
FS-21:feature/scripttype_playspeech
Open

Restored ScritType action 24 - Play speech with index...#1900
FS-21 wants to merge 5 commits into
Phobos-developers:developfrom
FS-21:feature/scripttype_playspeech

Conversation

@FS-21

@FS-21 FS-21 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

RA2/YR doesn't have implemented the Tiberian Sun action "24" (Play Speech). It just marks the action ended and then jumps to the next action from the script list.

  • Given a speech index, the game will play it. Just like action 24 from Tiberian Sun.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=24,n

Already tested in my mod and very simple action.

- Given a speech index, the game will play it. Just like action 24 from Tiberian Sun.

In `aimd.ini`:
```ini
[SOMESCRIPTTYPE]  ; ScriptType
x=19000,n
```
@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Metadorius

Copy link
Copy Markdown
Member

Why not restore action 24 if it exists in YR?

@FS-21

FS-21 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

I'm a bit ashamed, I always though lower numbers used by the game or Ares couldn't be readed by Phobos (I don't know why I was thinking that) but I just renamed the 19000 to 24 of this new action and put some breakpoints and efectively the code was executed.
Since the original RA2/YR action 24 only does a "pTeam->StepCompleted = true;" all is fine -_-'

Updated with value 24 instead of 19000.

@Metadorius

Copy link
Copy Markdown
Member

Nothing to be ashamed of friend, we all do those silly mistakes sometimes.

@FS-21 FS-21 changed the title ScritType action 19000 - Play speech with index... Restored ScritType action 24- Play speech with index... Oct 9, 2025
@FS-21 FS-21 changed the title Restored ScritType action 24- Play speech with index... Restored ScritType action 24 - Play speech with index... Oct 9, 2025

@TaranDahl TaranDahl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FS-21

FS-21 commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

I don't mind renaming this but I only use the naming commonly used in FinalSun, FinalAlert2, WAE and all knowledge pages like ModEnc.

@TaranDahl

Copy link
Copy Markdown
Contributor

I don't mind renaming this but I only use the naming commonly used in FinalSun, FinalAlert2, WAE and all knowledge pages like ModEnc.

I see. No problem then.

@TaranDahl TaranDahl added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants