Open
Conversation
Owner
|
Interesting, I had not considered this. Perhaps we could rely on |
Contributor
Author
|
Good idea, force-pushed. |
7c95dc6 to
fae0c5f
Compare
Owner
|
I just tested this and it does not allow overriding the I am not sure it is valuable to add multiple ways of doing the same thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m using the
redis-cacheplugin, which already puts a heavy load on the Redis server. So it makes sense to create a second server on another port. Unfortunately, redis-cache uses the same WP_REDIS_* constants, which is very inconvenient.I understand that this commit breaks backward compatibility, but it wouldn’t hurt to merge it at some point.