Fix project creation permissions using creatorHatIds #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem Users couldn't create projects despite having executive/admin roles because the frontend was checking the wrong permission level. The TaskManager has TWO permission levels: 1. creatorHatIds (TaskManager-level): Who can CREATE PROJECTS 2. rolePermProj (Project-level): Who can CREATE/CLAIM/REVIEW/ASSIGN TASKS The frontend was conflating these two levels. ## Solution - Fetch `creatorHatIds` from TaskManager entity in subgraph - Use `creatorHatIds` to check project creation permission - Add fallback for orgs deployed before subgraph update - Add project-level permission helpers for task operations ## Changes - queries.js: Add creatorHatIds to FETCH_ORG_FULL_DATA and FETCH_PROJECTS_DATA_NEW - POContext.js: Expose creatorHatIds from taskManager - ProjectSidebar.js: Use creatorHatIds for canManageProjects check - MainLayout.js: Pass roleHatIds when creating projects for default permissions - TaskColumn.js: Use project rolePermissions for task operations - permissions.js: New util with TaskPermission constants and helpers - ErrorParser.js: Add TaskManager custom error messages (NotCreator, etc) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
creatorHatIdsfrom TaskManager subgraph entity to check project creation permissionProblem
The TaskManager has TWO permission levels that were being conflated:
creatorHatIds(TaskManager-level): Who can CREATE PROJECTSrolePermProj(Project-level): Who can CREATE/CLAIM/REVIEW/ASSIGN TASKSChanges
queries.jscreatorHatIdsto GraphQL queriesPOContext.jscreatorHatIdsfrom taskManagerProjectSidebar.jscreatorHatIdsfor canManageProjects checkMainLayout.jsroleHatIdswhen creating projects for default permissionsTaskColumn.jsrolePermissionsfor task operationspermissions.jsErrorParser.jsDependencies
Requires subgraph PR to be merged first:
PerpetualOrganizationArchitect/subgraph-pop#24
Test plan
🤖 Generated with Claude Code