-
Notifications
You must be signed in to change notification settings - Fork 1
Per 10106 supply fa token #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e988a8b
to
b185009
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 44.56% 44.55% -0.01%
==========================================
Files 369 369
Lines 11283 11283
Branches 1850 1850
==========================================
- Hits 5028 5027 -1
- Misses 6084 6086 +2
+ Partials 171 170 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tweaks based on what we learned in our pairing.
README.md
Outdated
``` | ||
|
||
Depending on your system configuration, the test runner (Karma) may start a web server and make you manually navigate to a URL to run tests in your actual browser. To run tests directly in the terminal, you may need to pass in a `CHROME_BIN` environment variable to point to your installation of Google Chrome. | ||
|
||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some blocks have padding whitespace and others don't -- let's be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping this -- basically I think the missing instances of "```" earlier led to all this!
Let's just clean it all up.
b185009
to
c4942d2
Compare
c4942d2
to
39e4e8d
Compare
README.md
Outdated
``` | ||
|
||
Depending on your system configuration, the test runner (Karma) may start a web server and make you manually navigate to a URL to run tests in your actual browser. To run tests directly in the terminal, you may need to pass in a `CHROME_BIN` environment variable to point to your installation of Google Chrome. | ||
|
||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping this -- basically I think the missing instances of "```" earlier led to all this!
Let's just clean it all up.
@slifty prettier is doing all those changes so I have to see what is going on |
39e4e8d
to
d1d4bed
Compare
@slifty this should work now. Fun fact, if you right click the Readme file, you can click "Click to Preview" in VSCode and it opens a preview of the file! |
If you look at just the raw version of the md there is a lot of odd stuff going on.
Are you using a tool to edit this file? I'd recommend just editing the raw text by hand. |
d1d4bed
to
c82f933
Compare
@slifty which code blocks are you referring to? I checked in the preview and it looked alright to me |
c82f933
to
c9958db
Compare
c9958db
to
ab60d1e
Compare
This pull request adds the FontAwesome token to the .env file