Skip to content

Per 10106 supply fa token #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Per 10106 supply fa token #593

merged 2 commits into from
Jul 14, 2025

Conversation

crisnicandrei
Copy link
Contributor

This pull request adds the FontAwesome token to the .env file

@crisnicandrei crisnicandrei requested a review from slifty July 9, 2025 14:24
@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from e988a8b to b185009 Compare July 9, 2025 14:28
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (2861c0e) to head (ab60d1e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   44.56%   44.55%   -0.01%     
==========================================
  Files         369      369              
  Lines       11283    11283              
  Branches     1850     1850              
==========================================
- Hits         5028     5027       -1     
- Misses       6084     6086       +2     
+ Partials      171      170       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tweaks based on what we learned in our pairing.

README.md Outdated
```

Depending on your system configuration, the test runner (Karma) may start a web server and make you manually navigate to a URL to run tests in your actual browser. To run tests directly in the terminal, you may need to pass in a `CHROME_BIN` environment variable to point to your installation of Google Chrome.

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some blocks have padding whitespace and others don't -- let's be consistent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping this -- basically I think the missing instances of "```" earlier led to all this!

Let's just clean it all up.

@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from b185009 to c4942d2 Compare July 9, 2025 17:27
@crisnicandrei crisnicandrei requested a review from slifty July 9, 2025 17:27
@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from c4942d2 to 39e4e8d Compare July 9, 2025 17:35
README.md Outdated
```

Depending on your system configuration, the test runner (Karma) may start a web server and make you manually navigate to a URL to run tests in your actual browser. To run tests directly in the terminal, you may need to pass in a `CHROME_BIN` environment variable to point to your installation of Google Chrome.

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping this -- basically I think the missing instances of "```" earlier led to all this!

Let's just clean it all up.

@crisnicandrei
Copy link
Contributor Author

@slifty prettier is doing all those changes so I have to see what is going on

@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from 39e4e8d to d1d4bed Compare July 10, 2025 16:49
@crisnicandrei crisnicandrei requested a review from slifty July 10, 2025 16:51
@crisnicandrei
Copy link
Contributor Author

@slifty this should work now. Fun fact, if you right click the Readme file, you can click "Click to Preview" in VSCode and it opens a preview of the file!

@slifty
Copy link
Contributor

slifty commented Jul 10, 2025

If you look at just the raw version of the md there is a lot of odd stuff going on.

  1. Instructions that are marked as a header ###
  2. Normal text that is wrapped in a "```md" block
  3. code blocks that still aren't closed

Are you using a tool to edit this file? I'd recommend just editing the raw text by hand.

@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from d1d4bed to c82f933 Compare July 10, 2025 17:48
@crisnicandrei
Copy link
Contributor Author

@slifty which code blocks are you referring to? I checked in the preview and it looked alright to me

@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from c82f933 to c9958db Compare July 11, 2025 13:03
@crisnicandrei crisnicandrei force-pushed the PER-10106-supply-fa-token branch from c9958db to ab60d1e Compare July 14, 2025 16:26
@crisnicandrei crisnicandrei merged commit 1a459fc into main Jul 14, 2025
5 checks passed
@crisnicandrei crisnicandrei deleted the PER-10106-supply-fa-token branch July 14, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants