Create file viewer v2 #582
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PER-10107-implement-unlisted-share-page-ui #582 +/- ##
==============================================================================
+ Coverage 44.82% 44.96% +0.14%
==============================================================================
Files 370 373 +3
Lines 11361 11813 +452
Branches 1870 1971 +101
==============================================================================
+ Hits 5092 5312 +220
- Misses 6093 6314 +221
- Partials 176 187 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Create new file list v2 component -Create new file list v2 component for the viewer -Add params in the url instead of query params
crisnicandrei
force-pushed
the
create-file-viewer-v2
branch
from
e4c3a14 to
6069cdd
Compare
use record id instead of archive number when v2 navigating
crisnicandrei
force-pushed
the
create-file-viewer-v2
branch
2 times, most recently
from
7f4a163 to
deb4209
Compare
Fix arrow navigation
crisnicandrei
force-pushed
the
create-file-viewer-v2
branch
from
deb4209 to
bdf7c09
Compare
move the dialog display outside the share preview
crisnicandrei
force-pushed
the
create-file-viewer-v2
branch
from
6f16faa to
64b8687
Compare
crisnicandrei
force-pushed
the
create-file-viewer-v2
branch
from
6883294 to
7857f9a
Compare
crisnicandrei
force-pushed
the
create-file-viewer-v2
branch
from
e8e2fde to
74a4bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request is the second part of the new unlisted share functionality
This adds a new file-viewer which handles v2 api calls and a file list v2 component