Skip to content

PER-10096-archive-invitations #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crisnicandrei
Copy link
Contributor

@crisnicandrei crisnicandrei commented Jun 3, 2025

How to test:

  1. Have account A invite account B to Permanent (Account B must have an account)
  2. Account B must receive an email whilst logged in and click the link
  3. Account B should be redirected to the pending archives modal

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.88%. Comparing base (78aac96) to head (33b173e).

Files with missing lines Patch % Lines
...my-archives-dialog/my-archives-dialog.component.ts 72.72% 3 Missing ⚠️
...nts/account-dropdown/account-dropdown.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   44.59%   44.88%   +0.28%     
==========================================
  Files         369      369              
  Lines       11279    11299      +20     
  Branches     1849     1852       +3     
==========================================
+ Hits         5030     5071      +41     
+ Misses       6079     6056      -23     
- Partials      170      172       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crisnicandrei crisnicandrei force-pushed the PER-10096-archive-invitation-email-redirect-to-pending-archives branch 2 times, most recently from e50504e to 1946df0 Compare June 3, 2025 23:28
PER-10096-archive-invitations

-Create new route for archives dialog
-Redirect that new route based on the url to the pending archives dialog
@crisnicandrei crisnicandrei force-pushed the PER-10096-archive-invitation-email-redirect-to-pending-archives branch from 1946df0 to 33b173e Compare June 3, 2025 23:33
Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good -- ready for QA testing!

@slifty slifty requested review from cecilia-donnelly and removed request for omnignorant July 7, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants