-
Notifications
You must be signed in to change notification settings - Fork 1
Per 10107 implement unlisted share page UI #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crisnicandrei
wants to merge
8
commits into
main
Choose a base branch
from
PER-10107-implement-unlisted-share-page-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have replaced the previous share link api calls with the new ones, so that we can generate the new share URLs manually.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 44.50% 44.82% +0.31%
==========================================
Files 369 370 +1
Lines 11279 11361 +82
Branches 1849 1870 +21
==========================================
+ Hits 5020 5092 +72
- Misses 6088 6093 +5
- Partials 171 176 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4a1e5d0
to
25ec2cb
Compare
- Changed the previous resolver to use the new api calls - Small changes to the components to accomodate the new variables from the api call because of their new names in the api response (archiveNbr changed to archiveNumber for example)
25ec2cb
to
f0195c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the new API changes and api fields to the share modal in the web-app. This also creates a new share link which displays the items in the preview view as before, but does not open them in the file viewer, because I will make a separate pull request for that, so this one doesn't get too large.
Previously I did it in this pull request, but the new v2 api makes it a bit more challenging so I had to drop that idea and will move it into another pr which will be branched off of this one.