Skip to content

Per 10107 implement unlisted share page UI #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

crisnicandrei
Copy link
Contributor

This pull request adds the new API changes and api fields to the share modal in the web-app. This also creates a new share link which displays the items in the preview view as before, but does not open them in the file viewer, because I will make a separate pull request for that, so this one doesn't get too large.

Previously I did it in this pull request, but the new v2 api makes it a bit more challenging so I had to drop that idea and will move it into another pr which will be branched off of this one.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 54.20168% with 109 lines in your changes missing coverage. Please review.

Project coverage is 44.82%. Comparing base (17d6225) to head (f0195c7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...le-browser/components/sharing/sharing.component.ts 0.00% 32 Missing ⚠️
...are-link-settings/share-link-settings.component.ts 78.29% 23 Missing and 5 partials ⚠️
src/app/shared/services/api/folder.repo.ts 0.00% 17 Missing ⚠️
src/app/core/resolves/folder-resolve.service.ts 0.00% 5 Missing ⚠️
...ponents/file-list-item/file-list-item.component.ts 0.00% 5 Missing ⚠️
...omponents/share-preview/share-preview.component.ts 68.75% 3 Missing and 2 partials ⚠️
src/app/shared/services/api/record.repo.ts 55.55% 3 Missing and 1 partial ⚠️
src/app/core/services/edit/edit.service.ts 25.00% 3 Missing ⚠️
src/app/shared/services/data/data.service.ts 0.00% 0 Missing and 3 partials ⚠️
src/app/shared/services/http-v2/http-v2.service.ts 25.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   44.50%   44.82%   +0.31%     
==========================================
  Files         369      370       +1     
  Lines       11279    11361      +82     
  Branches     1849     1870      +21     
==========================================
+ Hits         5020     5092      +72     
- Misses       6088     6093       +5     
- Partials      171      176       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crisnicandrei crisnicandrei force-pushed the PER-10107-implement-unlisted-share-page-ui branch 2 times, most recently from 4a1e5d0 to 25ec2cb Compare June 3, 2025 12:19
- Changed the previous resolver to use the new api calls
- Small changes to the components to accomodate the new variables from the api call because of their new names in the api response (archiveNbr changed to archiveNumber for example)
@crisnicandrei crisnicandrei force-pushed the PER-10107-implement-unlisted-share-page-ui branch from 25ec2cb to f0195c7 Compare June 3, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant