Skip to content

PER-10200 Web app display error on multi part uploads #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crisnicandrei
Copy link
Contributor

Steps to test:

  1. Upload a large file (200MB approx)
  2. No error should be displayed after uploading

@crisnicandrei crisnicandrei force-pushed the PER-10200-web-app-error-large-files-uploading branch from b828fe7 to b127429 Compare May 27, 2025 13:23
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.74%. Comparing base (17d6225) to head (a33799e).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/app/shared/services/api/record.repo.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   44.50%   44.74%   +0.24%     
==========================================
  Files         369      369              
  Lines       11279    11283       +4     
  Branches     1849     1850       +1     
==========================================
+ Hits         5020     5049      +29     
+ Misses       6088     6067      -21     
+ Partials      171      167       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crisnicandrei crisnicandrei force-pushed the PER-10200-web-app-error-large-files-uploading branch 2 times, most recently from 8efc98e to 06f34cd Compare May 27, 2025 13:45
Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused -- I see one change to the the uploader logic which forcefully overrides the type of the return value registerMultipartRecord and removes a call to getRecordVO().

Does registerMultipartRecord's promise truly return a RecordVO instead of the documented RecordResponse?

If so, we need to update the type definition.

What was the runtime issue that was resulting in the original error and how does this resolve that? What changed that causes response to be a recordVO? Does it ALWAYS return a recordVO directly or only in the case of a multipart upload?

@crisnicandrei
Copy link
Contributor Author

@slifty changed the function, but i dont really know what to do about that response in the uploader, because it s looking for a RecordVO

@crisnicandrei crisnicandrei requested a review from slifty June 24, 2025 21:50
Fix response from multi part upload
@crisnicandrei crisnicandrei force-pushed the PER-10200-web-app-error-large-files-uploading branch from f3dd0ff to a33799e Compare July 1, 2025 14:03
Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you!

And thank you again for the pairing this morning to talk through the typing.

@slifty slifty requested a review from cecilia-donnelly July 7, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants