regen/locale.pl: Use 'USE_LOCALE" not 'NO_LOCALE' #23431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NO_LOCALE is a Configure option used to override setting the internal option USE_LOCALE. Internal checks should use the internal version. Not doing this caused z/OS to think it should be using locales on threaded systems, whereas it shouldn't. FYI, the reason this is is that the OS refuses to change the locale at all once a second thread is started. Perl relies on the ability to change the locale at will to accommodate locales that have a comma be the radix (decimal point) character and the huge amount of code that has been written expecting that at all times a dot is the radix character. This includes core code (which we could change) and XS code (which would be overwhelming to change).
It shouldn't be getting set anyway, but this makes it clear, and also makes sure someone hasn't tried to define it with Configure
|
I dont see anything wrong with this commit, fixing up usage of 2 #defines with direct opposite conflicting meanings is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_LOCALE is a Configure option used to override setting the internal
option USE_LOCALE. Internal checks should use the internal version.
Not doing this caused z/OS to think it should be using locales on
threaded systems, whereas it shouldn't.
FYI, the reason this is is that the OS refuses to change the locale at
all once a second thread is started. Perl relies on the ability to
change the locale at will to accommodate locales that have a comma be the
radix (decimal point) character and the huge amount of code that has
been written expecting that at all times a dot is the radix character.
This includes core code (which we could change) and XS code (which would
be overwhelming to change).
.