fixing bug (#27) and updating tests #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug being fixed manifested when perl was built when CC was gcc with as a path, usually as a full path to gcc, e.g., "/path/to/gcc". Support for full path gcc was added to _update_supported. Added tests for different perls and different gccs to ensure the fix; fixed the Windows test and removed linux tests from ci.yml. Darwin tests are still breaking.
|
@mohawk2, @kiwiroy, @zmughal would appreciate a review at your convenience - also, darwin tests were and are still breaking. I fixed windows pretty easily using I found this issue via |
kiwiroy
reviewed
Mar 12, 2025
Co-authored-by: Roy Storey <[email protected]>
…ame compiler and switch to cc from ccname
Improving detection of whether /g?cc/ is clang on Darwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug (#27) being fixed manifested when perl was built when CC is gcc with a path, usually as a full path to gcc, e.g.,
/path/to/gcc.Support for full path gcc was added to _update_supported.
Added tests for different perls and different gccs to ensure the fix; fixed the Windows test and removed linux tests from ci.yml.
Darwin tests are still breaking.