actual filename and filename attribute #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from file. However, even if object was created from a file, created object does not know name of the file it was created from. It makes error reporting difficult. Code changed to let constructor save filename for latter use. BTW, filename attribute introduced. It allows to specify filename even if an object was created from a string. It may be useful if caller code reads file and creates PPI document from a string. See also: Perl-Critic#180
wchristian
force-pushed
the
master
branch
4 times, most recently
from
07cd2bb to
46e810f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPI::Documentconstructor creates an object either from string or from file. However, even if object was created from a file, created object does not know name of the file it was created from. It makes error reporting difficult.Code changed to let constructor save filename for latter use. BTW,
filenameconstructor attribute introduced. It allows to specify filename even if an object is creating from a string. It may be useful if caller code reads file and creates PPI document from a string.Test added. All the tests (including the new one) pass on my system.
See also: #180