4 series updates #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- still need to add in console commands
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the 4 Series EPI and adjusts the build and update-readme workflows accordingly. Key changes include:
- Removal of the CustomValuesConfigObject.cs file.
- Addition of a workflow to generate READMEs.
- Extension of the build workflow to include a dedicated job for 4 Series builds.
Reviewed Changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| epi-utilities-custom-values/CustomValuesConfigObject.cs | Deprecated configuration file removed. |
| .github/workflows/essentialsplugins-updatereadme-caller.yml | New workflow file to trigger README generation. |
| .github/workflows/EssentialsPlugins-builds-caller.yml | Workflow updated to include a 4 Series build job. |
Files not reviewed (2)
- .github/workflows/essentialsplugins-betabuilds-caller.yml: Language not supported
- .github/workflows/essentialsplugins-releasebuilds-caller.yml: Language not supported
jkdevito
reviewed
Apr 24, 2025
jkdevito
reviewed
Apr 24, 2025
Contributor
jkdevito
left a comment
jkdevito
left a comment
There was a problem hiding this comment.
Added comments for review.
jkdevito
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Add 4 series support. This 4Series EPI has been successfully tested with Essentials Version: 2.4.6.]