feat: implement IHasFeedback interface in IEssentialsRoomFusionContro…

[ndorin]

This pull request enhances the feedback mechanism for the IEssentialsRoomFusionController class by implementing the IHasFeedback interface and ensuring all relevant feedback properties are initialized and added to the feedback collection during construction. The changes streamline feedback management and improve consistency in how feedback is exposed for room fusion controllers.

Feedback mechanism improvements:

• Implemented the IHasFeedback interface for IEssentialsRoomFusionController, allowing the class to expose a unified feedback collection.
• Added a FeedbackCollection<Feedback> property named Feedbacks to the class, making feedbacks accessible and manageable.

Feedback initialization and management:

• Moved initialization of HelpRequestResponseFeedback, HelpRequestSentFeedback, and HelpRequestStatusFeedback from Initialize() to the constructor helper, ensuring they are set up during object construction. [1] [2]
• Added all relevant feedback instances (HelpRequestResponseFeedback, HelpRequestSentFeedback, HelpRequestStatusFeedback, RoomOccupancyRemoteStringFeedback, and RoomIsOccupiedFeedback) to the Feedbacks collection in the constructor helper for consistent feedback registration.…ller

[Copilot]

Pull request overview

This pull request attempts to implement the IHasFeedback interface for IEssentialsRoomFusionController by adding a Feedbacks collection property and moving feedback initialization from the Initialize() method to the constructor. However, there are critical bugs introduced by this refactoring that will cause runtime failures.

Key changes:

• Added IHasFeedback interface implementation with a Feedbacks collection property
• Moved initialization of help request-related feedbacks (HelpRequestResponseFeedback, HelpRequestSentFeedback, HelpRequestStatusFeedback) from Initialize() to the constructor helper
• Added all feedbacks to the Feedbacks collection, including occupancy-related feedbacks
• Minor whitespace/formatting improvements

Critical Issues:
The refactoring introduces two critical bugs:

1. HelpRequestResponseFeedback is initialized in the constructor before FusionRoom is created, which will cause a NullReferenceException
2. Occupancy feedbacks (RoomOccupancyRemoteStringFeedback and RoomIsOccupiedFeedback) are conditionally initialized but unconditionally added to the collection, resulting in null values being added

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.